Skip to content

improve the tests with real KF profile namespaces #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 70 commits into from
Apr 14, 2025
Merged

improve the tests with real KF profile namespaces #3093

merged 70 commits into from
Apr 14, 2025

Conversation

kunal-511
Copy link
Contributor

@kunal-511 kunal-511 commented Apr 10, 2025 •
edited
Loading

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Added pending tests to end-to-end integration tests
Updated the katib and training operator to test in real KF profile namespace
Added missing things to the volume web application test

🐛 Related Issues

Fix #3054

✅ Contributor Checklist

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@kunal-511
Added more tests, updated the two gha workflow to test in real KF pro…
43fc126 
…file namespaces

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
resolved the wait error
2838f9b 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Ensuring proper storage class configuration in the KinD environment
9c01b31 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Added logs to know more about the error
f81d069 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@juliusvonkohout juliusvonkohout changed the title Added more tests, updated the two gha workflow to test in real KF pro… improve the tests with real KF profile namespaces Apr 10, 2025
@kunal-511
Added more comprehensive logging and diagnostics
78e3c9c 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
juliusvonkohout
juliusvonkohout reviewed Apr 10, 2025
View reviewed changes
juliusvonkohout
juliusvonkohout reviewed Apr 10, 2025
View reviewed changes
juliusvonkohout
juliusvonkohout reviewed Apr 10, 2025
View reviewed changes
juliusvonkohout
juliusvonkohout reviewed Apr 10, 2025
View reviewed changes
juliusvonkohout
juliusvonkohout reviewed Apr 10, 2025
View reviewed changes
juliusvonkohout
juliusvonkohout reviewed Apr 10, 2025
View reviewed changes
juliusvonkohout
juliusvonkohout reviewed Apr 10, 2025
View reviewed changes
@kunal-511
Removed the training operator from katib tests andusing volume api di…
b59e8b4 
…rectly

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Fixed the namespace error
8ff3e66 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Added echo for debugging the error
918c6cc 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511 kunal-511 marked this pull request as draft April 10, 2025 17:36
@kunal-511
Improved error handling and diagnostics
ae439db 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
removed the failing kubectl command
99524f4 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
removed the debuggers added
69143ec 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
fixed the service account token issue
89668db 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
removed the audience flag no needed
fd66098 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Fixed the unauth token probelm
c0d31be 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Added echo for logging
03fe07c 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Removed echo statements and reduce the timeout
7c7c64f 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Added logs to understand more about the error
19b12f7 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
juliusvonkohout and others added 8 commits April 14, 2025 10:05
@juliusvonkohout
Update volumes_web_application_test.yaml
8856569 
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Rename full_kubeflow_integration_test.yaml to end-to-end_integration_…
d67d26f 
…test.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Rename end-to-end_integration_test.yaml to full_kubeflow_integration_…
da2319f 
…test.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Update test_volumes_web_application.sh
46eb8cf 
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@kunal-511
disable injection in katib objects only
c9eb690 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@juliusvonkohout
Update test_volumes_web_application.sh
7f3804b 
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Update test_volumes_web_application.sh
f96e9b9 
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Update test_volumes_web_application.sh
8062a2c 
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Copy link
Member

@kunal-511 you can now continue with the API tests. I think you should be able to get it working.
image

juliusvonkohout
juliusvonkohout reviewed Apr 14, 2025
View reviewed changes
@kunal-511
Directly changed the file to disable injection
cb1c200 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
juliusvonkohout
juliusvonkohout reviewed Apr 14, 2025
View reviewed changes
tests/gh-actions/kf-objects/katib_test.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really just go for namespace: kubeflow-user-example-com and remove sed

juliusvonkohout
juliusvonkohout reviewed Apr 14, 2025
View reviewed changes
tests/gh-actions/kf-objects/kserve_test.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really just go for namespace: kubeflow-user-example-com and remove sed

@juliusvonkohout juliusvonkohout mentioned this pull request Apr 14, 2025
Closed
2 tasks
@kunal-511
added namespace directly to the test file
ce7fe94 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Fixed the XSRF-Token issue
9187f36 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Changed the Json payload a liitle bit
3700611 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Added echo to logs the error
7316156 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
fixed the access mode values
13857eb 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Fixing 403 error in PVC
c147106 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
removed the echo which was added to check the logs
7d6f4a7 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@juliusvonkohout
Copy link
Member

Amazing
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Apr 14, 2025
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1534a3b into kubeflow:master Apr 14, 2025
10 checks passed
milinddethe15 pushed a commit to milinddethe15/kf-manifests that referenced this pull request Apr 27, 2025
@kunal-511 @juliusvonkohout @milinddethe15
improve the tests with real KF profile namespaces (kubeflow#3093)
3d15852 
* Added more tests, updated the two gha workflow to test in real KF profile namespaces

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* resolved the wait error

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Ensuring proper storage class configuration in the KinD environment

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Added logs to know more about the error

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Added more comprehensive logging and diagnostics

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Removed the training operator from katib tests andusing volume api directly

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Fixed the namespace error

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Added echo for debugging the error

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Improved error handling and diagnostics

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* removed the failing kubectl command

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* removed the debuggers added

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* fixed the service account token issue

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* removed the audience flag no needed

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Fixed the unauth token probelm

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Added echo for logging

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Removed echo statements and reduce the timeout

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Added logs to understand more about the error

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Removed the echo logs

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Fixed crd issue in kserve test

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Fixed the timeout issue

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Fixed the training operator test issue

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Fixed the training operator test issue

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Fixed the namespace error in kserve test

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Fixed lint error

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Update .github/workflows/full_kubeflow_integration_test.yaml

Co-authored-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Kunal Dugar <yoyokvunal@gmail.com>

* Updated the names as suggested

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Updated the tests with tracking the success and removing sleep

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Fixed deployment name

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Added to check the actual labels

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Added the echo to check the CSRF token issue

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Added the echo to check the CSRF token issue

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Fixed the volume test issue

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Added the result checker

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Added logs to check the issue

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Fixed the lint issue

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Fixed the volume tests

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* fixed issues as suggested

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Improved the katib tests

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Update katib_test.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update full_kubeflow_integration_test.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update test_volumes_web_app.sh

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update and rename test_volumes_web_app.sh to test_volumes_web_application.sh

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update full_kubeflow_integration_test.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Disabled the istio injection for katib

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* reverted back

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Update and rename volumes_web_application_test.yaml to install_volumes_web_application.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Rename install_volumes_web_application.yaml to test_volumes_web_application.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update and rename install_volumes_web_app.sh to install_volumes_web_application.sh

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update test_volumes_web_application.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Rename test_volumes_web_application.yaml to volumes_web_application_test.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update volumes_web_application_test.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update test_volumes_web_application.sh

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update test_volumes_web_application.sh

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update full_kubeflow_integration_test.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update volumes_web_application_test.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Rename full_kubeflow_integration_test.yaml to end-to-end_integration_test.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Rename end-to-end_integration_test.yaml to full_kubeflow_integration_test.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update test_volumes_web_application.sh

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* disable injection in katib objects only

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Update test_volumes_web_application.sh

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update test_volumes_web_application.sh

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update test_volumes_web_application.sh

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Directly changed the file to disable injection

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* added namespace directly to the test file

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Fixed the XSRF-Token issue

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Changed the Json payload a liitle bit

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Added echo to logs the error

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* fixed the access mode values

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Fixing 403 error in PVC

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* removed the echo which was added to check the logs

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

---------

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Signed-off-by: Kunal Dugar <yoyokvunal@gmail.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Co-authored-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
@kunal-511 kunal-511 deleted the fix#3054/end-to-end-integration-tests-and-restructuring branch July 18, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

@juliusvonkohout juliusvonkohout Awaiting requested review from juliusvonkohout

Assignees

@juliusvonkohout juliusvonkohout

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

end-to-end integration tests and restructuring

2 participants

@kunal-511 @juliusvonkohout