-
Notifications
You must be signed in to change notification settings - Fork 960
feat: check resource usage in full_kubeflow_integration_test
and add section of resource utilization of each component in README
#3091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please use always rebase in the future instead of the merge from master as you did. |
Probably its best to create a new fresh PR from scratch and not use merge from master in the future, because i think it messes up files and commit history |
b6d428e
to
08a5410
Compare
I have fixed the commits in this PR itself. Now, I will add the components' resource usage table in README |
That looks good. Now we just need to generate the markdown table at the end with the maximum of actual usage and requests. |
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
Signed-off-by: milinddethe15 <milinddethe15@gmail.com>
@juliusvonkohout I am not sure how to structure the documentation but I gave a try. |
full_kubeflow_integration_test
and add section of resource utilization of each component in README
Looks good, In the end you need to automatically first calculate maximum of actual usage and requests for cpu/memory/storage per pod. So a triplet per pod: (1.maximum(cpu usage,cpu request), 2. maximum(memory usage, memory request), 3. size in GB of mounted PVCs) After having done this you can aggregate/summarize pods by components via the labels (pipelines, katib, istio etc) and then print this as markdown table in the GHA itself.
|
Pull Request Template for Kubeflow Manifests
✏️ Summary of Changes
with this PR I'm trying to run the kubeflow ecosytem onubuntu-latest-16-cores runner
(instead of using my local cluster) and checking the resources consumption of components by modifying the full_kubeflow_integration_test to just deploy the components (I removed the tests to get minimum usage of pods) and read the usage using metrics-server.We aren't merging this PR.
full_kubeflow_integration_test
using metrics-server📦 Dependencies
🐛 Related Issues
fixes #3083
✅ Contributor Checklist