Limit Istio Sidecar Scope to reduce memory and make cluster more scalable #3052
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| apiVersion: networking.istio.io/v1alpha3 | ||
| kind: Sidecar | ||
| metadata: | ||
| name: prune-egress | ||
| spec: | ||
| egress: | ||
| - hosts: | ||
| - "./*" # use mTLS within the namespace | ||
| - "kubeflow/*" # use mTLS when communicating with kubeflow namespace | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that block stuff that is not on the servicemesh by default ? E.g. talking from your jupyterlab to a deployment in the same namespace with istio-injection disabled. Or egress to a non-istio native kubernetes service in another namespaces or just the internet in general. Because that must be still allowed. Maybe we could just block inter kubeflow-profile namespace communication by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes all traffic is still allowed, this rule just removes mTLS and egress rules from being enforced, which I don't think we have any anyways. The "./*" still enables mTLS in the same namespace. See the istio documentation for details. I would love to hear from a kubeflow istio person about this idea
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have many mtls rules for the namespace "kubeflow". Please check the destination rules in the manifests first. We should not prune the existing explicit ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These destination rules all point to other services in the "kubeflow" namespace, which this policy allows. If you want, we can also have this policy only apply to user namespaces (kubeflow-*) by using a kyverno policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is "kubeflow", knative-serving, istio-system, oauth2-proxy etc whil the user namespaces are named arbitrarily. They could be thisismycoolusernamespace. Also kyverno is not yet part of the default platform and we need to work with the tools that are there by default.
"These destination rules all point to other services in the "kubeflow" namespace, which this policy allows" if that is true it might work. but please add a test in this PR here to verify the functionality (connection and mtls).