-
Notifications
You must be signed in to change notification settings - Fork 960
fix warnings in model-registry #2997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix warnings in model-registry #2997
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
03f4231
to
6ac01f8
Compare
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
@juliusvonkohout i can not build the kustomization.yaml after using edit fix --vars command, it seems that the auto-fix could not find a parameter,
|
Can you try to do the changes directly here https://github.com/kubeflow/model-registry from where the manifests are synchronized from? |
yes, i'll do so. thank you. |
can you please rebase both PRs ? so this one and kubeflow/model-registry#813 ? |
yes, ill do it tomorrow, hope it's fine with you. |
Signed-off-by: Mahdi Khashan <58775404+mahdikhashan@users.noreply.github.com>
done. |
And fix the tests with a zero diff ;-) |
sure. i'll do it asap. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@vikas-saxena02 do you want to continue here ? |
@juliusvonkohout I jsut took a look, this is an MR on manifest repo itself... dont we first fix upstream and then run the sync script here? |
Yes, I think the upstream one is kubeflow/model-registry#813 |
Pull Request Template for Kubeflow Manifests
✏️ Summary of Changes
📦 Dependencies
🐛 Related Issues
part of #2991
✅ Contributor Checklist