Skip to content

Conversation

@akagami-harsh
Copy link
Contributor

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I changed ...

📦 List any dependencies that are required for this change

My PR depends on #

🐛 If this PR is related to an issue, please put the link to the issue here.

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Feb 5, 2025

By the way you can in general run our documentation (al markdown files in the repository) trough LLMs to ask for consistency issues, spelling errors etc.

hansinikarunarathne and others added 3 commits February 7, 2025 15:06
Signed-off-by: Hansini Karunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: Your Name <hpotpose62@gmail.com>
Signed-off-by: Your Name <hpotpose62@gmail.com>
@akagami-harsh akagami-harsh force-pushed the fix-raycluster branch 2 times, most recently from 32894e8 to debe838 Compare February 7, 2025 09:48
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Feb 7, 2025
Signed-off-by: Your Name <hpotpose62@gmail.com>
@akagami-harsh
Copy link
Contributor Author

Used llm's to review the docs and fixed several spelling errors in the readmes

@juliusvonkohout
Copy link
Member

thank you
/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 59d1312 into kubeflow:master Feb 7, 2025
13 checks passed
@akagami-harsh akagami-harsh deleted the fix-raycluster branch February 7, 2025 15:18
pschoen-itsc pushed a commit to pschoen-itsc/kf-manifests that referenced this pull request Apr 25, 2025
* Update inf on create namespace step

Signed-off-by: Hansini Karunarathne <107214435+hansinikarunarathne@users.noreply.github.com>

* use master branch

Signed-off-by: Your Name <hpotpose62@gmail.com>

* fix kustomization file

Signed-off-by: Your Name <hpotpose62@gmail.com>

* fix readme.md typos

Signed-off-by: Your Name <hpotpose62@gmail.com>

---------

Signed-off-by: Hansini Karunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: Your Name <hpotpose62@gmail.com>
Co-authored-by: Hansini Karunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants