Skip to content

Conversation

tarekabouzeid
Copy link
Member

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I changed upgraded to istio 1.23.2

📦 List any dependencies that are required for this change

My PR depends on #

🐛 If this PR is related to an issue, please put the link to the issue here.

The following issues are related, because kubeflow 1.10

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>
@juliusvonkohout
Copy link
Member

Hello, thank you for the PR.
Please also update istio-cni, check whether there is outdated documentation/files and whether you missed any of the tests.

@tarekabouzeid
Copy link
Member Author

@juliusvonkohout

isition-cni: Yes, will do that as well, shall i do it as a separate PR or have it in this one as well?

regarding testing: I tested the example installation in local kind cluster, seems to work (Dex, notebook, dashboard browsing other components), are there any specific tests i need to run ?

@juliusvonkohout
Copy link
Member

A separate PR for istio-cni is also fine. But i will only merge them after the 1.9.1 final release

@juliusvonkohout
Copy link
Member

@tarekabouzeid please provide the Istio-cni PR as well. I want to merge them only together.

@tarekabouzeid
Copy link
Member Author

@tarekabouzeid please provide the Istio-cni PR as well. I want to merge them only together.

@juliusvonkohout I will create it today

@juliusvonkohout
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 26d970d into kubeflow:master Nov 4, 2024
27 checks passed
juliusvonkohout pushed a commit to tarekabouzeid/manifests that referenced this pull request Nov 4, 2024
Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>
google-oss-prow bot pushed a commit that referenced this pull request Nov 4, 2024
* Upgrade istio-cni to v.1.23.2

Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>

* update Readme file to fix Kustomize links and Tekton pipelines information (#2906)

Signed-off-by: varodrig <varodrig@redhat.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade istio to v.1.23.2 (#2890)

Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>

---------

Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>
Signed-off-by: varodrig <varodrig@redhat.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Co-authored-by: Valentina Rodriguez Sosa <64439402+varodrig@users.noreply.github.com>
pschoen-itsc pushed a commit to pschoen-itsc/kf-manifests that referenced this pull request Apr 25, 2025
Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
pschoen-itsc pushed a commit to pschoen-itsc/kf-manifests that referenced this pull request Apr 25, 2025
* Upgrade istio-cni to v.1.23.2

Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>

* update Readme file to fix Kustomize links and Tekton pipelines information (kubeflow#2906)

Signed-off-by: varodrig <varodrig@redhat.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade istio to v.1.23.2 (kubeflow#2890)

Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>

---------

Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>
Signed-off-by: varodrig <varodrig@redhat.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Co-authored-by: Valentina Rodriguez Sosa <64439402+varodrig@users.noreply.github.com>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants