Update kubeflow/pipelines manifests from 2.3.0 #2872
Conversation
| - cluster.local/ns/kubeflow/sa/ml-pipeline-scheduledworkflow | ||
| - cluster.local/ns/kubeflow/sa/ml-pipeline-viewer-crd-service-account | ||
| - cluster.local/ns/kubeflow/sa/kubeflow-pipelines-cache | ||
| # allow access by any trusted principal |
There was a problem hiding this comment.
Here I will have to merge another PR first and help
There was a problem hiding this comment.
I will fix it probably on Sunday and then merge. Otherwise it looks good.
|
You need to sign your commits according to DCO. |
Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>
Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>
tarekabouzeid
force-pushed
the
synchronize-kubeflow-pipelines-manifests-2.3.0
branch
from
1c387a7 to
41acc32
Compare
|
No worries "HTTP response body: RBAC: access denied" in the tests is expected. I have to merge the authentication PR first and adjust this one here to fix it. |
|
/lgtm |
|
@tarekabouzeid There is one test failling. Can you take a look? /hold |
As described above I will fix that on the weekend. But feel free to continue with the synchronization of other components. |
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
|
Well hopefully argo updates to kustomize 5 soon, but that is out of scope for this PR. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
3 participants
Pull Request Template for Kubeflow manifests Issues
✏️ A brief description of the changes
📦 List any dependencies that are required for this change
🐛 If this PR is related to an issue, please put the link to the issue here.
✅ Contributor checklist
DCOcheck)