Skip to content

New fixing kustomize5 warning #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 13, 2025
Merged

New fixing kustomize5 warning #2549

merged 11 commits into from
May 13, 2025

Conversation

vikas-saxena02
Copy link
Contributor

@vikas-saxena02 vikas-saxena02 commented May 12, 2025 •
edited
Loading

What this PR does / why we need it:

Fixes kubeflow/manifests#2985

Checklist:

  • Docs included if any changes are user facing

@vikas-saxena02
ran kustomize edit fix for katib-cert-manager
e24d5e7 
Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>
@vikas-saxena02
ran kustomize edit fix for katib-external-db
d4c8202 
Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>
@vikas-saxena02
fixed up comments
3acdb8f 
Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>
@vikas-saxena02
fixed build error with katib-cert-maanager
8d0ad87 
Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>
@vikas-saxena02
fixed up comments in katib-external-db
da63ec6 
Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>
@vikas-saxena02
fixed warnings in katib-leader-election
5befc17 
Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>
@vikas-saxena02
fixed warnings in katib-openshift
58aef20 
Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>
@vikas-saxena02
fixed warnings in katib-standalone-postgres
1621386 
Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>
@vikas-saxena02
fixed warnings in katib-with-kubeflow
0272b83 
Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>
@vikas-saxena02
fixed up comments
f8bfecd 
Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>
@vikas-saxena02
Copy link
Contributor Author

vikas-saxena02 commented May 12, 2025 •
edited
Loading

No modules report any changes as part of running diff -u
Screenshot 2025-05-12 at 9 24 55 pm

Screenshot 2025-05-12 at 10 26 47 pm

@vikas-saxena02
Copy link
Contributor Author

/retest

@vikas-saxena02 vikas-saxena02 mentioned this pull request May 12, 2025
Closed
1 task
@vikas-saxena02
Copy link
Contributor Author

@tenzen-y @juliusvonkohout @andreyvelich can you please review this?

@vikas-saxena02
fixing diffs errors in the updated code
a6c92ed 
Signed-off-by: Vikas Saxena <Vikas.Saxena.2006@gmail.com>
andreyvelich
andreyvelich reviewed May 12, 2025
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, thank you @vikas-saxena02!
/lgtm
/assign @tenzen-y @Electronic-Waste @mahdikhashan @helenxie-bit
Please can you help with review ?

@google-oss-prow google-oss-prow bot added the lgtm label May 12, 2025
Electronic-Waste
Electronic-Waste approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikas-saxena02 Thanks for this. LGTM!

/lgtm

@vikas-saxena02
Copy link
Contributor Author

@vikas-saxena02 Thanks for this. LGTM!

/lgtm

@Electronic-Waste @andreyvelich can you please approve this as well as the bot is waiting for approved label to merge this.

tenzen-y
tenzen-y reviewed May 13, 2025
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you
/lgtm
/approve

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 9421f23 into kubeflow:master May 13, 2025
68 of 69 checks passed
@juliusvonkohout juliusvonkohout mentioned this pull request Jun 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreyvelich andreyvelich andreyvelich left review comments

@anencore94 anencore94 Awaiting requested review from anencore94

+2 more reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@Electronic-Waste Electronic-Waste Electronic-Waste approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andreyvelich andreyvelich

@mahdikhashan mahdikhashan

@tenzen-y tenzen-y

@Electronic-Waste Electronic-Waste

@helenxie-bit helenxie-bit

Labels

approved lgtm size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

KATIB upstream manifest fixes

6 participants

@vikas-saxena02 @andreyvelich @tenzen-y @Electronic-Waste @mahdikhashan @helenxie-bit