Skip to content

fake-client in UTs #2541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fake-client in UTs #2541

wants to merge 1 commit into from

Conversation

Garvit-77
Copy link

What this PR does / why we need it:
This PR implements Changes of UTs with fake client instead of gomock
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2408

Checklist:

  • [Y] Docs included if any changes are user facing

Signed-off-by: Garvit Khandelwal <70192868+Garvit-77@users.noreply.github.com>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gaocegege for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Garvit-77
Copy link
Author

Hey @tenzen-y
Please let me know any changes and
I think KatibClientMock does have the function for handling fake client should i create that with this pr ?

Copy link

github-actions bot commented Jul 9, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

This pull request has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@github-actions github-actions bot closed this Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace go mock with client-go fake client in unit tests
1 participant