-
Notifications
You must be signed in to change notification settings - Fork 488
stop running e2etest when katib not available #2538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop running e2etest when katib not available #2538
Conversation
@Rahul-Kumar-prog thank you for this pr, would you please sign your commits? |
Hey @mahdikhashan is this good? |
Signed-off-by: Rahul-kumar-prog <rahulkumarrsde@gmail.com>
Signed-off-by: Rahul-kumar-prog <rahulkumarrsde@gmail.com>
e4b9974
to
a7c4db5
Compare
/ok-to-test |
@kubeflow/wg-automl-leads could you please trigger the workflow for this pr? |
SGTM, let's check the workflow. |
/rerun-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anencore94 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Could you provide some examples when Katib is not available? @Rahul-Kumar-prog |
this addresses local cluster. |
Should I have to edit it ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the context @mahdikhashan. And also appreciate your work @Rahul-Kumar-prog, I left my initial reviews for you:)
/cc @kubeflow/wg-automl-leads @helenxie-bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also check the status of katib in: https://github.com/kubeflow/katib/blob/master/test/e2e/v1beta1/scripts/gh-actions/run-e2e-experiment.sh ?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it. |
What this PR does / why we need it:
This Changes affect to the e2e test.
Previous behavior : when we run e2e test it continue testing even if the Katib is not available
Current behavior : now if the Katib is not available it will stop testing and if the katib is available only then it move further.
Fixes #2513