Skip to content

Conversation

Rahul-Kumar-prog
Copy link

@Rahul-Kumar-prog Rahul-Kumar-prog commented Mar 29, 2025

What this PR does / why we need it:
This Changes affect to the e2e test.
Previous behavior : when we run e2e test it continue testing even if the Katib is not available
Current behavior : now if the Katib is not available it will stop testing and if the katib is available only then it move further.

Fixes #2513

@mahdikhashan
Copy link
Member

@Rahul-Kumar-prog thank you for this pr, would you please sign your commits?

@Rahul-Kumar-prog
Copy link
Author

Hey @mahdikhashan is this good?
let me know I am doing this sign for the first time.

Signed-off-by: Rahul-kumar-prog <rahulkumarrsde@gmail.com>
Signed-off-by: Rahul-kumar-prog <rahulkumarrsde@gmail.com>
@Rahul-Kumar-prog Rahul-Kumar-prog force-pushed the Stop-running-e2etest-when-katib-not-available branch from e4b9974 to a7c4db5 Compare March 30, 2025 20:56
@mahdikhashan
Copy link
Member

/ok-to-test

@mahdikhashan
Copy link
Member

@kubeflow/wg-automl-leads could you please trigger the workflow for this pr?
cc: @helenxie-bit @Electronic-Waste

@mahdikhashan
Copy link
Member

Hey @mahdikhashan is this good? let me know I am doing this sign for the first time.

SGTM, let's check the workflow.

@Electronic-Waste
Copy link
Member

/rerun-all

Copy link
Member

@anencore94 anencore94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anencore94
Once this PR has been reviewed and has the lgtm label, please assign gaocegege for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Electronic-Waste
Copy link
Member

Previous behavior : when we run e2e test it continue testing even if the Katib is not available

Could you provide some examples when Katib is not available? @Rahul-Kumar-prog

@mahdikhashan
Copy link
Member

Previous behavior : when we run e2e test it continue testing even if the Katib is not available

Could you provide some examples when Katib is not available? @Rahul-Kumar-prog

this addresses local cluster.

@Rahul-Kumar-prog
Copy link
Author

What this PR does / why we need it:

This Changes affect to the e2e test.

Previous behavior : when we run e2e test it continue testing even if the Katib is not available

Current behavior : now if the Katib is not available it will stop testing and if the katib is available only then it move further.

Fixes #2513

Should I have to edit it ?

Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context @mahdikhashan. And also appreciate your work @Rahul-Kumar-prog, I left my initial reviews for you:)

/cc @kubeflow/wg-automl-leads @helenxie-bit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@google-oss-prow google-oss-prow bot requested review from a team and helenxie-bit April 2, 2025 03:44
Copy link

github-actions bot commented Jul 1, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

This pull request has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@github-actions github-actions bot closed this Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TEST] when running e2e tests on local, when the katib is not available - it should exit without continuting to run tests

4 participants