[feature] migrate docker images to ghcr #2520

mahdikhashan · 2025-02-27T11:26:27Z

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2519

Checklist:

Docs included if any changes are user facing

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

mahdikhashan · 2025-02-27T11:30:55Z

/cc @kubeflow/wg-automl-leads @Electronic-Waste @varodrig

PTAL!

mahdikhashan · 2025-02-27T11:51:49Z

please refer to this published image on my own user, https://github.com/mahdikhashan/katib/pkgs/container/katib-conformance

and this temp workflow where i disabled release branch check: https://github.com/mahdikhashan/katib/actions/runs/13565650050/job/37918014229

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

Electronic-Waste

@mahdikhashan Thanks for this! Just one comment for you.

Electronic-Waste · 2025-03-02T06:03:35Z

.github/workflows/build-and-publish-images.yaml

        uses: ./.github/workflows/template-publish-image
        with:
-          image: docker.io/kubeflowkatib/${{ inputs.component-name }}
+          image: ghcr.io/kubeflowkatib/${{ inputs.component-name }}


I think, the naming convention in GHCR should be ghcr.io/<org name or user name>/....

So the second item between /s might need to be changed to kubeflow

@mahdikhashan, please address this one and push images both into DockerHub and GHCR.

sure, i'll do so.

I think, the naming convention in GHCR should be ghcr.io/<org name or user name>/....

So the second item between /s might need to be changed to kubeflow

done.

@mahdikhashan, please address this one and push images both into DockerHub and GHCR.

done. please take a look when you have time. thanks.

Electronic-Waste · 2025-03-02T06:08:56Z

And maybe we should also fix the image reference under manifests/, examples/, pkg/, test/ and hack/.

mahdikhashan · 2025-03-02T18:38:30Z

And maybe we should also fix the image reference under manifests/, examples/, pkg/, test/ and hack/.

tnx for your review Shao, will address them asap.

mahdikhashan · 2025-03-16T15:34:24Z

i assume here i also need to consider both dockerhub and ghcr, please correct me if i'm wrong. otherwise, i will change it to have both.

@varodrig @andreyvelich ..

mahdikhashan · 2025-03-16T15:40:30Z

And maybe we should also fix the image reference under manifests/, examples/, pkg/, test/ and hack/.

possibly tests will fail, we created a separate pr for manifests for trainer, I'll do so here as well to prevent merge blocking.

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

mahdikhashan · 2025-03-17T09:08:50Z

And maybe we should also fix the image reference under manifests/, examples/, pkg/, test/ and hack/.

this is being addressed here #2529

cc: @Electronic-Waste

Electronic-Waste · 2025-03-17T15:22:34Z

/rerun-all

saileshd1402 · 2025-03-18T12:08:56Z

Please combine the Dockerhub and GHCR CI jobs like done here: kubeflow/trainer#2537

mahdikhashan · 2025-03-18T12:42:01Z

Please combine the Dockerhub and GHCR CI jobs like done here: kubeflow/trainer#2537

for sure, thanks for bringing this to my attention. i'll do it asap.

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

mahdikhashan · 2025-03-18T18:07:51Z

/cc @kubeflow/wg-automl-leads @Electronic-Waste @saileshd1402

PTAL!

google-oss-prow · 2025-03-18T18:07:55Z

@mahdikhashan: GitHub didn't allow me to request PR reviews from the following users: saileshd1402.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kubeflow/wg-automl-leads @Electronic-Waste @saileshd1402

PTAL!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

andreyvelich · 2025-03-18T18:20:19Z

.github/workflows/build-and-publish-images.yaml

-          image: docker.io/kubeflowkatib/${{ inputs.component-name }}
+          image: |
+            ghcr.io/kubeflow/katib/${{ inputs.component-name }}
+            docker.io/kubeflow/katib/${{ inputs.component-name }}


This should be kubeflowkatib

i'll revert it to prevent docker failure. thanks for bringing this up.

andreyvelich · 2025-03-18T18:20:27Z

.github/workflows/build-and-publish-images.yaml

-          image: docker.io/kubeflowkatib/${{ inputs.component-name }}
+          image: |
+            ghcr.io/kubeflow/katib/${{ inputs.component-name }}
+            docker.io/kubeflow/katib/${{ inputs.component-name }}


i'll revert it to prevent docker failure. thanks for bringing this up.

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

andreyvelich

Thanks for doing this @mahdikhashan!
/lgtm
/approve

Let's cherry-pick this PR if images are published.

google-oss-prow · 2025-03-18T18:38:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [andreyvelich]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andreyvelich · 2025-03-18T20:30:47Z

/cherry-pick release-0.18

google-oss-robot · 2025-03-18T20:31:34Z

@andreyvelich: new pull request created: #2531

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow bot added the size/M label Feb 27, 2025

google-oss-prow bot requested review from Electronic-Waste and anencore94 February 27, 2025 11:26

mahdikhashan added 6 commits February 27, 2025 12:29

update custom action

de3d4c4

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

define token as input

6d5f8a2

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

clean up meta job

244f2c5

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

change build-and-publish-imageg.yaml

0032e47

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

remove secret from workflow call

919795f

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

remove docker credentials from publish* images

47bddb3

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

mahdikhashan force-pushed the migrate-docker-images-to-ghcr branch from 24a1d7a to 47bddb3 Compare February 27, 2025 11:29

google-oss-prow bot requested review from a team and varodrig February 27, 2025 11:30

google-oss-prow bot added size/S and removed size/M labels Feb 27, 2025

mahdikhashan force-pushed the migrate-docker-images-to-ghcr branch from d9e30ac to 503fa11 Compare February 27, 2025 12:08

mahdikhashan added 2 commits February 27, 2025 13:08

revert meta step changes

2e6e5bc

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

revert changes

213242d

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

mahdikhashan force-pushed the migrate-docker-images-to-ghcr branch from 503fa11 to 213242d Compare February 27, 2025 12:08

Electronic-Waste reviewed Mar 2, 2025

View reviewed changes

mahdikhashan added 2 commits March 17, 2025 09:07

update

82d0163

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

add dockerhub as a job

1e802f1

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

google-oss-prow bot added size/M and removed size/S labels Mar 17, 2025

revert secrets

337f950

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

mahdikhashan added 2 commits March 17, 2025 09:39

revert docker secrets

ad3091e

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

revert docker secrets

3a4eb08

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

mahdikhashan mentioned this pull request Mar 17, 2025

[feature] move manifest image references to ghcr #2529

Merged

1 task

mahdikhashan requested review from Electronic-Waste and tenzen-y March 17, 2025 09:12

consolidate/merge registeries

e945484

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

fix inputs

901c341

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

andreyvelich reviewed Mar 18, 2025

View reviewed changes

mahdikhashan requested a review from andreyvelich March 18, 2025 18:20

revert docker path name

d4448c4

Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>

andreyvelich reviewed Mar 18, 2025

View reviewed changes

google-oss-prow bot assigned andreyvelich Mar 18, 2025

google-oss-prow bot added the lgtm label Mar 18, 2025

google-oss-prow bot added the approved label Mar 18, 2025

google-oss-prow bot merged commit 1f76bb3 into kubeflow:master Mar 18, 2025
66 checks passed

google-oss-robot mentioned this pull request Mar 18, 2025

[release-0.18] [feature] migrate docker images to ghcr #2531

Merged

[feature] migrate docker images to ghcr #2520

[feature] migrate docker images to ghcr #2520

Uh oh!

Conversation

mahdikhashan commented Feb 27, 2025

Uh oh!

mahdikhashan commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mahdikhashan commented Feb 27, 2025

Uh oh!

Electronic-Waste left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Electronic-Waste commented Mar 2, 2025

Uh oh!

mahdikhashan commented Mar 2, 2025

Uh oh!

mahdikhashan commented Mar 16, 2025

Uh oh!

mahdikhashan commented Mar 16, 2025

Uh oh!

mahdikhashan commented Mar 17, 2025

Uh oh!

Electronic-Waste commented Mar 17, 2025

Uh oh!

saileshd1402 commented Mar 18, 2025

Uh oh!

mahdikhashan commented Mar 18, 2025

Uh oh!

mahdikhashan commented Mar 18, 2025

Uh oh!

google-oss-prow bot commented Mar 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andreyvelich left a comment

Choose a reason for hiding this comment

Uh oh!

google-oss-prow bot commented Mar 18, 2025

Uh oh!

Uh oh!

andreyvelich commented Mar 18, 2025

Uh oh!

google-oss-robot commented Mar 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mahdikhashan commented Feb 27, 2025 •

edited

Loading