Skip to content

feat: add config validation #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2024
Merged

feat: add config validation #93

merged 1 commit into from
Nov 11, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Nov 8, 2024

Overview

  1. The assembled config is converted into the internally used config, via mapstructure and decode-hooks.
  2. Then the imported otel-collector config validator will handle the heavy-lifting.

@csatib02 csatib02 added the enhancement New feature or request label Nov 8, 2024
@csatib02 csatib02 self-assigned this Nov 8, 2024
@csatib02 csatib02 force-pushed the feat/add-config-validation branch from 508da84 to 6a30431 Compare November 8, 2024 14:49
pepov
pepov approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@pepov pepov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:godmode:

Base automatically changed from feat/stabilize-operator-behaviour to main November 11, 2024 08:29
@csatib02 csatib02 force-pushed the feat/add-config-validation branch 3 times, most recently from 6b4f493 to e8ad8f5 Compare November 11, 2024 08:37
@csatib02
feat: add config-validation
fec702f 
Signed-off-by: Bence Csati <bence.csati@axoflow.com>
@csatib02 csatib02 force-pushed the feat/add-config-validation branch from e8ad8f5 to fec702f Compare November 11, 2024 08:40
OverOrion
OverOrion approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job! 🚀

@csatib02 csatib02 merged commit cd5d00e into main Nov 11, 2024
11 checks passed
@csatib02 csatib02 deleted the feat/add-config-validation branch November 11, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepov pepov pepov approved these changes

@OverOrion OverOrion OverOrion approved these changes

@kristofgyuracz kristofgyuracz Awaiting requested review from kristofgyuracz

Assignees

@csatib02 csatib02

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csatib02 @pepov @OverOrion