Skip to content

feat: add possibility to inject auth info from secrets #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

kristofgyuracz
Copy link
Collaborator

No description provided.

@kristofgyuracz kristofgyuracz force-pushed the secret-auth branch 2 times, most recently from 36cf40e to 534ece7 Compare October 4, 2024 08:12
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@kristofgyuracz kristofgyuracz marked this pull request as ready for review October 4, 2024 08:55
Copy link
Collaborator

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, once the secret watcher is added it should work just fine. 🚀

Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
Signed-off-by: Kristof Gyuracz <kristof.gyuracz@axoflow.com>
@kristofgyuracz kristofgyuracz requested a review from tarokkk October 7, 2024 08:54
Copy link
Contributor

@tarokkk tarokkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kristofgyuracz kristofgyuracz merged commit e687718 into main Oct 11, 2024
13 checks passed
@kristofgyuracz kristofgyuracz deleted the secret-auth branch October 11, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants