Skip to content

Conversation

tobi-jolly
Copy link

What has been changed

  • Updated date_time_extension.dart to allow users to choose between 12h and 24h time formats instead of forcing one.

Why it has been changed

  • Some users prefer 12h format while others prefer 24h. This change respects the user’s system or app setting.

How it has been changed

  • Used use24HourFormat check to decide format dynamically.
  • Verified the fix on:
    • Android (emulator)
    • Browser (Chromium based, Microsoft Edge)
    • Browser (Chromium based, Chrome)

Notes

  • Code formatted with dart format and imports sorted with dart run import_sorter:main --no-comments.
  • Commit follows the Conventional Commits format.

Copy link
Owner

@krille-chan krille-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with the recent changes on e584c22 which fixes the behavior on iOS. This now changes the behavior on iOS to always ignore the user pref. The commit message says this makes it user-configurable, while the user cannot configure anything here (I would vote against such a config anyway)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants