Skip to content

Conversation

avashilling
Copy link
Contributor

Also changes reaction wrap alignment to line up with own message better (right to left, this fixes jerky movement when a reaction is added or removed from ones own message), and adds a burst animation when reactions are removed.

Thank you so much for your contribution to FluffyChat ❤️❤️❤️

Please make sure that your Pull Request meet the following acceptance criteria:

  • Code formatting and import sorting has been done with dart format lib/ test/ and dart run import_sorter:main --no-comments
  • The commit message uses the format of Conventional Commits
  • The commit message describes what has been changed, why it has been changed and how it has been changed
  • Every new feature or change of the design/GUI is linked to an approved design proposal in an issue
  • Every new feature in the app or the build system has a strategy how this will be tested and maintained from now on for every release, e.g. a volunteer who takes over maintainership

Pull Request has been tested on:

  • Android
  • iOS
  • Browser (Chromium based)
  • Browser (Firefox based)
  • Browser (WebKit based)
  • Desktop Linux
  • Desktop Windows
  • Desktop macOS

Also changes reaction wrap alignment to line up with own message better, and adds a burst animation when reactions are removed.
@avashilling avashilling requested a review from krille-chan as a code owner July 30, 2025 20:35
Copy link
Owner

@krille-chan krille-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR but this is a very huge change. Such huge changes should better be discussed in an issue before to avoid frustration if those get rejected :-/

@avashilling
Copy link
Contributor Author

@krille-chan I see, my bad! Should I make an issue to discuss it now, or is it too large of a change to be accepted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants