-
-
Notifications
You must be signed in to change notification settings - Fork 1k
SVG Sanitizer features added #2182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.1
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (4)
- composer.json: Language not supported
- packages/Webkul/Admin/src/Http/Controllers/TinyMCEController.php: Language not supported
- packages/Webkul/Admin/src/Resources/views/components/form/control-group/control.blade.php: Language not supported
- packages/Webkul/Core/src/Traits/Sanitizer.php: Language not supported
The SVG sanitiser feature has been implemented; however, a UI issue occurs during SVG image upload that needs to be addressed. Additionally, the password does not change after following the provided testing steps. |
File broken issue is not found in my instance. you need to verify it again. |
I have retested the issue—currently, the image is not visible after uploading. -----https://webkul.chatwhizz.com/share/view-recording/681456edc4a93f076923eab3 |
- Fix uploaded attachments not displaying properly - Fix TinyMCE editor not appearing after replying twice in mail view - Fix TinyMCE editor not loading in configuration page
I've tested this issue further and found that while the SVG file is no longer capable of changing admin credentials, it can still trigger an alert() message when opened in a new browser tab. |
Verified: The SVG file has been sanitized to remove embedded scripts for security compliance. As a result, any interactive features (such as JavaScript-based functionality) within the SVG no longer work when opened directly in a new tab. |
Issue Reference
https://gist.github.com/shellkraft/a8b1f35d5c3ba313605065889563fb00?permalink_comment_id=5524476#gistcomment-5524476
Description
SVG Sanitizer
How To Test This?
https://gist.github.com/shellkraft/a8b1f35d5c3ba313605065889563fb00?permalink_comment_id=5524476#gistcomment-5524476
Please follow the all process which is mentioned in video.