fix wipe effect skipping frames when rendering takes "too long" #739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
software mode at high resolutions takes longer to render and to dump frames than opengl at comparable resolutions. so more real time passes between frames, which makes the ending advance the melt effect further than normal on the next frame.
the code was always doing this, but it was written with much lower resolution in mind too, and viddump wasn't as widespread back then maybe?
now melt consistently takes 45 frames, even tho in
wipe_doMelt()
cph says it takes 25 for some reason (that whole comment kinda contradicts current reality anyway).fixes #714
Videos for comparison (software mode only, opengl looks similar but the pattern is slightly different):
320x240.mp4
2560x1440.mp4
3840x2160.mp4