-
Notifications
You must be signed in to change notification settings - Fork 111
Intermission "Now Entering" Extended Pause #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermission "Now Entering" Extended Pause #736
Conversation
However, I don't think this change is appropriate in DSDA-Doom. Edit: I didn't notice |
prboom2/src/wi_stuff.c
Outdated
WI_endStats(); | ||
} | ||
|
||
#define WI_INTERMISSION_PAUSE (!dsda_StrictMode() && allow_incompatibility && gamemode == commercial && !netgame) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why !dsda_StrictMode()
? It should be like this in any demo, so allow_incompatibility
is enough.
And maybe WI_LONGER_NOW_ENTERING
is better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess I was being extra careful... There's absolutely no way for dsda_StrictMode()
to be true unless it's either demo recording / playback, right?
While I'm not super crazy on the wording of WI_LONGER_NOW_ENTERING
, I'll admit it does do a better job of explaining it's purpose.
I think this is a good change for dsda-doom. Ive definetely seen requests to make the |
I like this feature, would love to port this over to Woof once it's done 🙂 |
We already have it for the ID24 intermissions. |
2da1ec9
to
193937c
Compare
Can you point me to this code? I'm curious on it's implementation. |
See the calls of |
- Skippable via keypress
193937c
to
2f95f08
Compare
This is a pretty simple PR. Many people complain (including me) that for Doom 2 you can't read the mapname on "Now Entering" screen, like in some other ports like GZDoom.
This PR adds an extended pause (not in demos) that is also skippable via a keypress.
I also threw in another fix that's tangentially related, which allows the "Now Entering" to show when entering MAP31. Currently it shows nothing when entering MAP31 (you can see this in Eviternity II). This is because this code was supposed to avoid the "Now Entering" for after MAP30 (i.e. next map would be MAP31), but ended up also not showing "Now Entering" for any map entering MAP31.