-
Notifications
You must be signed in to change notification settings - Fork 111
Heretic umapinfo support #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pedro-Beirao
wants to merge
21
commits into
kraflab:master
Choose a base branch
from
Pedro-Beirao:heretic-umapinfo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1084edd
to
41231b9
Compare
Heretic vanilla behaviour:
So to streamline this in UMAPINFO, if a level defines |
The actor names are still point of discussion, but the rest should be all ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #530
This is an attempt to implement umapinfo support in the current intermission/finale codebase. I will want to rewrite/refactor some of these files to better organize the specific intermission/finale code for doom, heretic and hexen, and the implementation of umapinfo. Currently, heretic and hexen are just "patched in" with the old doom code, making it hard to work with
Since there is no spec for umapinfo in heretic, I went with a mix of: do like vanilla heretic and do like doom's umapinfo
Old test wad: heretic-umapinfo.wad.zipTest wad: heretic-umapinfo.wad.zip