Little enhancement #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added multiple topic news * Added possibility to sort the news by the publish date * Added possibility to get the news published within the last X hours
* Added multiple topic news * Added possibility to sort the news by the publish date * Added possibility to get the news published within the last X hours
Generic enhancement for this repo. I needed these functions. * Added multiple geolocation news * Added multiple topic news * Added possibility to sort the news by the publish date * Added possibility to get the news published within the last X hours
* Added multiple topic news * Added possibility to sort the news by the publish date * Added possibility to get the news published within the last X hours
|
LGTM! |
|
Hello, Thank you for your contribution to the pygooglenews package! I’ve recently taken over the maintenance of this project and I really appreciate your efforts in improving it. I’d be happy to merge this pull request, but I noticed an issue that needs to be addressed before proceeding. The new features rely on published_parsed to sort articles by date. However, if this key is missing in some entries from feedparser, it could cause errors. For example, mktime(p['published_parsed']) may raise an exception if p['published_parsed'] is None. Could you please add a check to handle cases where published_parsed is not present? Let me know if you need any help with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added some features that i was needing for my project.
Thank you for this repo!