Skip to content

Conversation

@brian-kelley
Copy link
Contributor

@brian-kelley brian-kelley commented Oct 21, 2025

Remove these macros that were deprecated in 4.x versions:

  • __KOKKOSBATCHED_ENABLE_LAPACKE__
  • __KOKKOSBATCHED_ENABLE_INTEL_MKL_COMPACT_BATCHED__
  • __KOKKOSBATCHED_PROMOTION__
  • __KOKKOSBATCHED_ENABLE_INTEL_MKL__
  • __KOKKOSBATCHED_ENABLE_INTEL_MKL_BATCHED__

__KOKKOSBATCHED_ENABLE_AVX__ was already removed from the code, but was still on the deprecations page of the documentation.

This should be included in the 5.0 release if possible.

@brian-kelley brian-kelley requested a review from lucbv October 21, 2025 21:20
@brian-kelley brian-kelley self-assigned this Oct 21, 2025
@brian-kelley brian-kelley added Cleanup Code maintenance that isn't a bugfix or new feature CI: skip-docs Do not run the documentation checks for this pull request labels Oct 21, 2025
Signed-off-by: Brian Kelley <bmkelle@sandia.gov>
@brian-kelley brian-kelley force-pushed the RemoveBatchedDeprecated branch from 76f763a to 7b157ef Compare October 22, 2025 15:03
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks for also updating the MKL compact batch macros

@lucbv lucbv merged commit f994357 into kokkos:develop Oct 22, 2025
25 checks passed
@brian-kelley brian-kelley deleted the RemoveBatchedDeprecated branch October 22, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: skip-docs Do not run the documentation checks for this pull request Cleanup Code maintenance that isn't a bugfix or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants