Skip to content

add pv.yml for SYCL testing on PVC arch #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

add pv.yml for SYCL testing on PVC arch #2676

wants to merge 3 commits into from

Conversation

@ndellingwood
Copy link
Contributor

No description provided.

@ndellingwood ndellingwood requested review from cwpearson and lucbv June 10, 2025 17:32
@ndellingwood ndellingwood added AT2-SPECIAL-APPROVAL Mark .github changes as approved. AT2-CI-APPROVAL Approve CI to run at SNL labels Jun 10, 2025
@ndellingwood
add pv.yml for SYCL testing on PVC arch
72a0e1b 
Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>
cwpearson
cwpearson requested changes Jun 10, 2025
View reviewed changes
@ndellingwood
Test removing step set_oneapi_device_selector_var
e9c6fee 
Address review comments

Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>
@ndellingwood
pv ci: test update of cxx flags
6d465be 
Signed-off-by: Nathan Ellingwood <ndellin@sandia.gov>
@ndellingwood
Copy link
Contributor Author

I'm a bit confused, we're using the AT2 registry image built from intel/oneapi-basekit:2024.2.1-0-devel-ubuntu22.04, but looking back at the configuration line it shows IntelLLVM 2025.0.4...

 -- Setting default Kokkos CXX standard to 17
-- The CXX compiler identification is IntelLLVM 2025.0.4
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /opt/intel/oneapi/compiler/2025.0/bin/icpx - skipped
...

That newer intel version has some sort of driver or lib incompatibility with the install on Blake, I'll open an issue with sys admins, but I don't understand the compiler mismatch from how the image was built

@lucbv
Copy link
Contributor

lucbv commented Jun 11, 2025

There is a job on blake going on for 6hrs in the PV queue, we should cancel that so we can get an interactive sessions and investigate a bit what's going.
Note that ocloc has to be installed on Blake otherwise we would get the same error with the 2024 toolchain so the issue is with us picking it up incorrectly in the image.

@ndellingwood
Copy link
Contributor Author

@lucbv the intel/oneapi-basekit:2024.2.1-0-devel-ubuntu22.04 image runs fine on Blake in the Kokkos CI, but we do need some sort of update to 2025.0

@cwpearson cwpearson self-requested a review June 11, 2025 19:23
@ndellingwood
Copy link
Contributor Author

Blake sysadmins are investigating the issues with use of intel/oneapi versions newer than 2024.2.1 , I'll retest the PR after the issues are resolved

masterleinad
masterleinad reviewed Jul 8, 2025
View reviewed changes
.github/workflows/pv.yml
type: string

jobs:
PR_PV_ONEAPI202410_SYCL:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PR_PV_ONEAPI202410_SYCL:
PR_PV_ONEAPI_2024_2_1_0_SYCL:

or at least include the second number in 2024.2.1.0.

.github/workflows/pv.yml
cmake \
-S "$PWD/.." \
-B "$PWD" \
-DCMAKE_BUILD_TYPE=Release \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id' expect that you also have to build Kokkos as shared library

Suggested change
-DCMAKE_BUILD_TYPE=Release \
-DBUILD_SHARED_LIBS=ON \
-DCMAKE_BUILD_TYPE=Release \

.github/workflows/pv.yml
-DKokkos_ENABLE_EXAMPLES=OFF \
-DKokkos_ENABLE_DEPRECATED_CODE_4=OFF \
-DKokkos_ENABLE_DEPRECATION_WARNINGS=OFF \
-DKokkos_ENABLE_ONEDPL=OFF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to disable oneDPL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwpearson cwpearson cwpearson approved these changes

@lucbv lucbv Awaiting requested review from lucbv

+1 more reviewer

@masterleinad masterleinad masterleinad left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AT2-CI-APPROVAL Approve CI to run at SNL AT2-SPECIAL-APPROVAL Mark .github changes as approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ndellingwood @lucbv @masterleinad @cwpearson