Skip to content

Move KokkosSparse::Experimental::SPTRSVAlgorithm to KokkosSparse::SPTRSVAlgorithm #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Move KokkosSparse::Experimental::SPTRSVAlgorithm to KokkosSparse::SPTRSVAlgorithm #2570

wants to merge 1 commit into from

Conversation

@jczhang07
Copy link
Contributor

No description provided.

@jczhang07 jczhang07 changed the base branch from develop to release-candidate-4.6.00 March 25, 2025 16:07
@cwpearson
Copy link
Contributor

@jczhang07 the DCO test is failing because you didn't sign off your commit

git commit --amend -s

# caution
git push -f
# caution

@cwpearson cwpearson added the AT2-CI-APPROVAL Approve CI to run at SNL label Mar 25, 2025
@lucbv
Copy link
Contributor

lucbv commented Mar 25, 2025

Instead of git push -f I would recommend git push origin +branch_name which only force branch_name to the remote

@jczhang07 jczhang07 force-pushed the 2025-03-25/move-SPTRSVAlgorithm-out-of-Experimental branch from 4542a9a to 34b7bd0 Compare March 25, 2025 17:23
@cwpearson cwpearson added AT2-CI-APPROVAL Approve CI to run at SNL and removed AT2-CI-APPROVAL Approve CI to run at SNL labels Mar 25, 2025
@lucbv lucbv requested review from cwpearson and lucbv March 26, 2025 19:53
lucbv
lucbv requested changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a bit of clean-up needed : )

@lucbv lucbv changed the base branch from release-candidate-4.6.00 to develop March 27, 2025 16:52
@jczhang07
sptrsv: move KokkosSparse::Experimental::SPTRSVAlgorithm to KokkosSpa…
0e71cb9 
…rse::SPTRSVAlgorithm

Signed-off-by: Junchao Zhang <jczhang@anl.gov>
@jczhang07 jczhang07 force-pushed the 2025-03-25/move-SPTRSVAlgorithm-out-of-Experimental branch from 506612b to 0e71cb9 Compare March 27, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucbv lucbv lucbv requested changes

@cwpearson cwpearson Awaiting requested review from cwpearson

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

AT2-CI-APPROVAL Approve CI to run at SNL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jczhang07 @cwpearson @lucbv