Add support for more complex types #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neocturne
force-pushed
the
more-types
branch
4 times, most recently
from
a85b71e to
9e1c252
Compare
|
Oh, I just found a few issues with the new code that are not covered by the tests yet. Will push an update later today. |
This rewrites a lot of the FieldKind and helper logic to make type resolution fully composable. This allows to use arbitrarily nested constructions of all supported types. All existing testcases pass without changes, and two new cases are added to demonstrate the new feature.
This just copies the logic for handling tuple and unit structs from IntoOwnedGen to BorrowedGen.
This tests build for various combinations of different types, in particular some involving cloned types in containers like Vec and Option.
…fields Avoid moving all inner fields or reimplementing clone(), thus generating shorter and in some cases possibly more efficient code. This is basically a regression fix for "feature: make field type resolution recursive", kept as a separate commit to make review easier. It should have no effect on which code does or does not compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly large overhaul of the field type logic, adding support for various new types:
Box<T>It also fixes deriving
Borrowedfor tuple structs, which was previously broken.All existing tests pass without changes, and I've added new testcases for all new features.
Fixes #13