Skip to content

Update IPEX libs #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2025
Merged

Update IPEX libs #2121

merged 1 commit into from
Jun 15, 2025

Conversation

Disty0
Copy link
Contributor

@Disty0 Disty0 commented Jun 13, 2025

Makes IPEX libs compatible with Torch 2.7+. required for Battlemage.
Removed gradscaler hijack module and uses the PyTorch built-in one instead.
Updates the deprecated OpenVINO device=GPU_FP32 syntax to device=GPU + precision=FP32 syntax.

Also side note, i do have my ipex libs as pip installable module via pip install git+https://github.com/Disty0/ipex_to_cuda
I can convert the lib in this repo to use external package so users can update it without a PR to sd-script if you want but that can be a security issue for you too.

@kohya-ss kohya-ss merged commit cadcd31 into kohya-ss:dev Jun 15, 2025
1 check passed
@kohya-ss
Copy link
Owner

Thank you for this!

Also side note, i do have my ipex libs as pip installable module via pip install git+https://github.com/Disty0/ipex_to_cuda
I can convert the lib in this repo to use external package so users can update it without a PR to sd-script if you want but that can be a security issue for you too.

That would be convenient for users. However, as you said, dependent libraries are a security issue.
If you don't mind, please submit a pull request and we'll merge it as soon as possible. If you want to switch to an installable module, please let us know.

@Disty0
Copy link
Contributor Author

Disty0 commented Jun 16, 2025

If you don't mind, please submit a pull request and we'll merge it as soon as possible. If you want to switch to an installable module, please let us know.

I don't really understand what you meant by that but i am fine with either of the option. I mentioned it in case if you prefer to use the ipex libs as a dependency instead of built-in to the codebase.

@kohya-ss
Copy link
Owner

I don't really understand what you meant by that but i am fine with either of the option. I mentioned it in case if you prefer to use the ipex libs as a dependency instead of built-in to the codebase.

Sorry for the confusion. I was wondering if opening a PR every time might be a burden for you. I think the current state is probably better for users because they can use it without having to do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants