[WIP] Add support for runtime filtering #947
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to discuss how a possible API could look, to set a global min log level, used for runtime filtering.
This PR adds
set_global_log_level
which stores the minimal log level in astatic AtomicU8
.Other approaches I could think of:
Logger
impl and let them figure out where they want to store the min log level. like inLog::enabled
of thelog
crateSidenotes:
IdRanges
struct that I have added in an earlier PR, but I realize now, that I could also pass the LogLevel from the macro implementation directly.