Skip to content

Conversation

@Joemires
Copy link

There's a problem when you are using

Route::apiResource('products', Controllers\Store\ProductController::class)->scoped(['product' => 'slug'])

The documentation still uses your getRouteKeyName model method and this is a great problem for people with special routes having their special scopes

@shalvah
Copy link
Contributor

shalvah commented Mar 26, 2025

I probably only know about 30% of Laravel features at this point. 😅

@shalvah
Copy link
Contributor

shalvah commented Mar 26, 2025

Please fix the tests + add a new one for this use case, if possible.

@shalvah
Copy link
Contributor

shalvah commented Apr 17, 2025

Tests fixed (wasn't your fault), but can you add a test for this too?

@Joemires
Copy link
Author

Hey @shalvah
Sorry I was busy with things

I'll look into this and revert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants