fix: crash when API resource __construct enforces type in ResponseFromApiResource #1028
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will check if the given resource is a collection or not without instantiating a new instance of the given class with MissingValue as first parameter.
Allows for overwriting the resources __contruct() to ensure type safety in resources, example:
```
class UserResource extends JsonResource
{
public function __construct(User $resource)
{
parent::__construct($resource);
}
public function toArray(Request $request): array
{
return [
'id' => $this->id,
];
}
}
```
mengidd
changed the title
|
Awesome, thank you 👏 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the ResponseFromApiResource attribute, scribe will crash if you overwrite the API resources __construct method to add proper type. Example:
This will give the following error
This PR fixes this issue, as scribe no longer instantiates a new resource class instance with MissingValue as first parameter to check if it's an instance of ResourceCollection.