Feature/refactor planning #726
Conversation
| /// For each variant of the variable order computation | ||
| /// contains one [HashSet] mapping each predicate to its available [ColumnOrder]s. | ||
| pub(crate) all_column_orders: Vec<HashMap<Tag, HashSet<ColumnOrder>>>, | ||
| pub(crate) _all_column_orders: Vec<HashMap<Tag, HashSet<ColumnOrder>>>, |
There was a problem hiding this comment.
Instead of renaming this, why not add #[allow(unused)]? Now this won't sort next to all_variable_orders in, e.g., autocomplete.
There was a problem hiding this comment.
Also, is this actually even unused?
There was a problem hiding this comment.
It is now. Before it was used to compute a variable order for additional rules using the existing column orders as input. Now everything is handled with the initial variable order.
| ImportInstruction::new(predicate, handler) | ||
| } | ||
|
|
||
| #[ignore] |
There was a problem hiding this comment.
I wanted to ask @monsterkrampe if he could take a look at it later, as I don't understand how my changes would affect the outcome of the variable order computation (and if this would even be a problem)
There was a problem hiding this comment.
Ok, should be fixed now
| (rules, variables, predicates) | ||
| } | ||
|
|
||
| #[ignore] |
There was a problem hiding this comment.
Same question, why is this ignored?
| UnionRange::NewExclusive => (step_last_application + 1)..step_current, | ||
| UnionRange::OldInclusive => 0..(step_last_application + 1), |
There was a problem hiding this comment.
Please use ..= instead of adding 1 and using exclusive ranges
There was a problem hiding this comment.
Apparently Range and RangeInclusive are different types
aannleax
force-pushed
the
feature/refactor-planning
branch
from
94fc828 to
d19caac
Compare
This PR replaces
ChaseRuleandRuleAnalysiswithNormalizedRules. It also reworks the planning code.