fix typos and upstream library.sh changes #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
approved
|
/lgtm |
knative-prow
bot
added
the
do-not-merge/hold
|
@upodroid do you want to merge this in or close out? |
|
oh whoops closed this by accident |
cardil
reviewed
Oct 3, 2025
Comment on lines
-644
to
-659
| group "Removing unwanted vendor files" | ||
|
|
||
| # Remove unwanted vendor files | ||
| find vendor/ \( -name "OWNERS" \ | ||
| -o -name "OWNERS_ALIASES" \ | ||
| -o -name "BUILD" \ | ||
| -o -name "BUILD.bazel" \ | ||
| -o -name "*_test.go" \) -exec rm -f {} + | ||
|
|
||
| export GOFLAGS=-mod=vendor | ||
|
|
||
| group "Updating licenses" | ||
| update_licenses third_party/VENDOR-LICENSE "./..." | ||
|
|
||
| group "Removing broken symlinks" | ||
| remove_broken_symlinks ./vendor |
There was a problem hiding this comment.
I think this is still needed, as not all repos are vendorless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of knative/infra#134
I'm putting this in a separate branch so the changes can be synced by knobots and avoid shipping this to other repos via go module.
Will merge this to main once all repos have been fixed.
/cc @kvmware @evankanderson