-
Notifications
You must be signed in to change notification settings - Fork 30
Fix #387 Panic if Redis client returns use of closed network connection #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix #387 Panic if Redis client returns use of closed network connection #628
Conversation
…d network connection
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tdeverdiere The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
if strings.Contains(strings.ToLower(err.Error()), "use of closed network connection") { // Redis has probably been shut down | ||
panic("Redis has been shut down") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a more graceful way to handle this error? From the original issue, it seems like the proposed solution is:
Eventing-redis should reopen a socket when the error is "use of closed network connection".
I imagine that with this panicking, it will eventually be restarted and that would reopen the socket. But, I feel like we could handle this more gracefully. WDYT?
This Pull Request is stale because it has been open for 90 days with |
Fixes #387
Proposed Changes
use of closed network connection