Skip to content

SmuView GUI blocking. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

SmuView GUI blocking. #30

wants to merge 1 commit into from

Conversation

danselmi
Copy link
Contributor

It tried to 'sync' both signals infinitely long.
But there are no further samples yet.
Tested with Aim-TTi CPX400P. I assume that the problem also occures with the Korad driver.

@danselmi
fix: SmuView blocks if the driver doesn't sample values at the same t…
a7c545e 
…imestamp.

It tries to 'sync' both signals infinitely long.

Tested with Aim-TTi CPX400P. I assume that the problem also
occures with the Korad driver.
@knarfS
Copy link
Owner

knarfS commented May 7, 2021 •
edited
Loading

Thanks for your PR. I can see the problem here, but I'm wondering why this has never happened to me...
It would be great, if you could attach a log output (SmuView started with smuview -d aim-tti-dps -l 5).

Maybe it's finally time for some unit tests :)

@danselmi
Copy link
Contributor Author

danselmi commented May 8, 2021

Sure, here it is:
aimttiSmuview.log

knarfS added a commit that referenced this pull request May 13, 2021
@knarfS
python: Add script to reproduce the bug fixed in PR #30.
1a28506
knarfS pushed a commit that referenced this pull request May 13, 2021
@danselmi @knarfS
AnalogTimeSignal: Fix bug in AnalogTimeSignal::combine_signals().
39aa6f1 
SmuView blocks when trying to combine two signals and at least one of them
doesn't have enough samples. It tries to 'sync' both signals infinitely long.

Tested with Aim-TTi CPX400P, but the problem also occurs with other drivers,
like the Korad driver.

Merged from Github PR #30 with cosmetic code changes.
@knarfS
Copy link
Owner

knarfS commented May 13, 2021

This PR was merge with commit 39aa6f1 and more bugs in AnalogTimeSignal::combine_signals() were fixed in b8d7d48.

I would appreciate it, if you could test my changes and let me know if everything works.

@knarfS knarfS closed this May 13, 2021
@danselmi
Copy link
Contributor Author

Yes, it works. The GUI is not blocking anymore. Thanks.

But I found another problem. Probably in the aim-tti driver maybe with others too. The regulation mode always updates channel 1.
I believe because the call sr_session_send_meta(sdi, SR_CONF_REGULATION, ... ) does not reference a specific channel. I don't know how to fix this.

@knarfS
Copy link
Owner

knarfS commented May 14, 2021

But I found another problem. Probably in the aim-tti driver maybe with others too. The regulation mode always updates channel 1.
I believe because the call sr_session_send_meta(sdi, SR_CONF_REGULATION, ... ) does not reference a specific channel.

This is a known limitation of libsigrok at the moment. There are two solutions for that, one of which gets hopefully merged into libsigrok at some point in the future:

  1. A suggestion from @fastflo that introduces a new config key: new SR_CONF_CHANNEL_GROUP meta package sigrokproject/libsigrok#101 and interpret ConfigKey::DataSource meta packets to select... #15
  2. A new property for the meta package, that would break the existing API: knarfS/libsigrok@80639b8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danselmi @knarfS