Content sync enhancement #1189
Open
Content sync enhancement #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of newline characters
…, and edit cancellation
…ng of escape characters
…d preview generation
Upgrading standard dompurify package breaks the khoj obsidian plugin. Isomorphic dompurify wraps the latest dompurify 3.2.6, works with the khoj obsidian plugin and is recommended on the dompurify npm package as well. So migrate to that
Ask khoj to return file edits in the SEARCH/REPLACE form. This is a more standard form, also used by aider. Remove json5 package as we now rely on regex to pars edit blocks from khoj's response Remove unused functions in chat_view.
Can re-nable if invalid edit blocks higher than tolerable and clean-up chat history clutter after edit block fixup retries
These should be used sparingly and in UX where icons do not work like error messages and notices.
- Show user profile picture or email initial if signed in - Show connection status as status dot - Add link to get khoj api key from khoj url - Add interact, connect section to improve setting groups
- Switch between similar and chat view in the same leaf node when opened via the header pane nav links - Only show new conversation when in chat view, not similar view - Put new conversation container after header row. Previously it would flex around in the header row which felt untidy.
- Introduced a progress bar for better user feedback during file uploads. - Improved logging for file synchronization, including success and error messages. - Added error handling for network issues and server responses, with retry logic for failed uploads. - Optimized batch processing to respect server limits and handle file deletions more effectively. - Updated console messages for clarity and user engagement.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 15894534 | Triggered | Generic High Entropy Secret | 6f21860 | docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a major synchronization bug in the Obsidian plugin with the Khoj backend.
Previously, if more than 1000 files were synchronized simultaneously, it would cause an error that interrupted the process, making it impossible to synchronize large vaults from scratch.
This pull request also adds console logging to track the progress of synchronization with the backend, which can sometimes be considerably slow and might worry the user.