Avoid publishing GH releases for main branch pushes #11290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: timflannagan <timflannagan@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the release pipeline to avoid publishing concrete GitHub releases for pushes to the main branch while still publishing artifacts.
- Update GoReleaser configuration to conditionally disable releases
- Modify the GitHub Actions workflow to set GORELEASER_DISABLE_RELEASE for main branch pushes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .goreleaser.yaml | Adds a conditional disable setting for release via environment variable |
| .github/workflows/release.yaml | Adjusts workflow steps to set the GORELEASER_DISABLE_RELEASE variable for pushes to main |
| if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} | ||
| continue-on-error: true | ||
| run: | |
There was a problem hiding this comment.
[nitpick] Consider adding a comment to clarify that this line conditionally disables the release publishing on main branch pushes, improving readability for future maintainers.
Suggested change
| run: | | |
| run: | | |
| # Disable release publishing when a push is made to the main branch. |
Copilot uses AI. Check for mistakes.
github-actions
bot
added
kind/cleanup
timflannagan
commented
May 27, 2025
yuval-k
approved these changes
May 27, 2025
|
FYI @nfuden |
timflannagan
commented
May 27, 2025
| @@ -173,6 +173,7 @@ docker_manifests: | |||
| changelog: | |||
| disable: true | |||
| release: | |||
| disable: '{{ if isEnvSet "GORELEASER_DISABLE_RELEASE" }}{{ .Env.GORELEASER_DISABLE_RELEASE }}{{ else }}false{{ end }}' | |||
There was a problem hiding this comment.
Only affects GH releases. Doesn't affect container image (or helm chart) publishing.
Implausiblyfun
approved these changes
May 28, 2025
nfuden
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the release pipeline to avoid publishing GH releases for pushes to main branch. Previously, both artifacts and a concrete GH release/tag would be published whenever a PR merged to main. Now, we publish artifacts but avoid publishing a concrete GH release for this event trigger.
Change Type
/kind cleanup
Changelog
Additional Notes
See #11286 for some context on this.