EP-11219: tls in xds #11221
Open
EP-11219: tls in xds #11221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a design document outlining the addition of one-way TLS support for kgateway-Envoy communication.
- Proposes TLS support using Kubernetes secrets for certificate configuration.
- Details server behavior for certificate updates and CA injection into Envoy's configuration.
|
|
||
| The TLS configuration will be handled by the kgateway xDS server: | ||
| - Load TLS certificates from the specified secret. | ||
| - if the secret is not found, the server will not start. |
There was a problem hiding this comment.
Consider elaborating on the failure mode when the TLS secret is missing, such as including potential error messages or operational guidance for debugging.
Copilot uses AI. Check for mistakes.
|
|
||
| ## Open Questions | ||
|
|
||
| 1. Any reason to use TLS version lower than TLS1.3? |
There was a problem hiding this comment.
[nitpick] It would be beneficial to include a recommended default for TLS protocol versions and cipher suites in the design to provide clear guidance on the security posture.
Copilot uses AI. Check for mistakes.
github-actions
bot
added
do-not-merge/release-note-invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind design