dynamic forward proxy #11197
Merged
dynamic forward proxy #11197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
yuval-k
commented
May 10, 2025
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Closed
…rd-proxy Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
github-actions
bot
added
kind/feature
jenshu
reviewed
Jun 2, 2025
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
…rd-proxy Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
jenshu
reviewed
Jun 4, 2025
| @@ -365,6 +375,11 @@ func (p *backendPlugin) HttpFilters(ctx context.Context, fc ir.FilterChainCommon | |||
| } | |||
| result = append(result, aiFilters...) | |||
| } | |||
| if p.needsDfpFilter[fc.FilterChainName] { | |||
| pluginStage := plugins.DuringStage(plugins.OutAuthStage) | |||
| f, _ := plugins.NewStagedFilter("envoy.filters.http.dynamic_forward_proxy", dfpFilterConfig, pluginStage) | |||
There was a problem hiding this comment.
if we're ignoring the error, should we use MustNewStagedFilter?
api/v1alpha1/backend_types.go
Outdated
| // The hostname will be used for SNI and auto SAN validation. | ||
| // +optional | ||
| // +kubebuilder:validation:Optional | ||
| Tls bool `json:"tls,omitempty"` |
There was a problem hiding this comment.
maybe rename to useTls or enableTls?
|
|
||
| var _ e2e.NewSuiteFunc = NewTestingSuite | ||
|
|
||
| // testingSuite is a suite of tests for ExtAuth functionality |
There was a problem hiding this comment.
Suggested change
| // testingSuite is a suite of tests for ExtAuth functionality | |
| // testingSuite is a suite of tests for Dynamic Forward Proxy functionality |
| }) | ||
| } | ||
|
|
||
| // TestExtAuthPolicy tests the basic ExtAuth functionality with header-based allow/deny |
jenshu
approved these changes
Jun 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jenshu
pushed a commit
to jenshu/kgateway
that referenced
this pull request
Jun 5, 2025
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com> Signed-off-by: Jenny Shu <jenny.shu@solo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for dynamic forward proxy.
Fixes #11326
Fixes #11312
Change Type
/kind feature
Changelog
Additional Notes
N/A