Skip to content

Add feature to allow enabling FIPS in rustls #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

behos
Copy link
Contributor

@behos behos commented Jul 11, 2025

In order to be able to enable fips when depending on the zookeeper client we need to allow setting the rustls feature.

@kezhuw
Copy link
Owner

kezhuw commented Jul 13, 2025

This does not sound enough to be fips compatible ?

https://docs.rs/rustls/latest/rustls/manual/_06_fips/index.html

Seems that we have to config an option to enable fips compatible crypto provider ?

@kezhuw
Copy link
Owner

kezhuw commented Jul 13, 2025

Seems that one could enable this implicit outside zookeeper-client by:

rustls::crypto::default_fips_provider().install_default()
    .expect("default provider already set elsewhere");

But we do have option to do this explict regardless of dependency or environment.

https://docs.rs/rustls/latest/rustls/crypto/fn.default_fips_provider.html

@kezhuw kezhuw closed this in a0bf8e5 Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants