Skip to content

📌 (feat) add external name service support #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.27
version: 0.1.28


# This is the version number of the application being deployed. This version number should be
Expand Down
2 changes: 1 addition & 1 deletion templates/pvc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ metadata:
chart: "{{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}"
spec:
accessModes:
- ReadWriteMany
{{- toYaml .Values.accessModes | nindent 2 }}
resources:
requests:
storage: {{ .Values.storage }}
Expand Down
6 changes: 5 additions & 1 deletion templates/service.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if eq .Values.service.enabled true }}
# Copyright 2020 Keyporttech Inc.
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -13,7 +14,6 @@
# This is a YAML-formatted file.
# Declare variables to be passed into your templates.


apiVersion: v1
kind: Service
metadata:
Expand All @@ -22,6 +22,9 @@ metadata:
{{- include "dynamodb-helm-chart.labels" . | nindent 4 }}
spec:
type: {{ .Values.service.type }}
{{- if .Values.service.externalName }}
externalName: {{ .Values.service.externalName | quote }}
{{- end }}
ports:
- port: 8000
targetPort: 8000
Expand All @@ -33,3 +36,4 @@ spec:
name: admin
selector:
{{- include "dynamodb-helm-chart.selectorLabels" . | nindent 4 }}
{{- end }}
9 changes: 8 additions & 1 deletion values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,11 @@ securityContext: {}
# runAsUser: 1000

service:
type: ClusterIP
enabled: true
type: ClusterIP # Can be ClusterIP or ExternalName

# If type: ExternalName
# externalName: ""

ingress:
enabled: false
Expand Down Expand Up @@ -95,6 +99,9 @@ affinity: {}
# type of storage pvc, directVolume -defaults to emptyDir
storageType: emptyDir

accessModes:
- ReadWriteMany

# example pvc values
# storage: "500Mi"
# storageClassName: ""
Expand Down