Skip to content

Minimize spread of CPU crunching times #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025

Conversation

justinformatik
Copy link
Collaborator

@justinformatik justinformatik commented Jun 26, 2025

BEGINRELEASENOTES

  • Minimalized spread of algorithm execution due to vector resizing and allocations in CPU crunching
    ENDRELEASENOTES

Removed push!(primes, n) from crunching. Impact is minimal.

@m-fila m-fila self-requested a review June 26, 2025 11:16
@m-fila m-fila changed the title Crunching Minimize spread of CPU crunching times Jun 26, 2025
@m-fila
Copy link
Member

m-fila commented Jun 26, 2025

Just for completeness the problem we had was that CPU-crunching had a significant spread of execution timing for the same requested time. For instance for ms scale that could be 2.5x difference between min and max for the same input value

This seems to fix #74

@m-fila m-fila linked an issue Jun 26, 2025 that may be closed by this pull request
@m-fila m-fila merged commit 5a9815f into key4hep:main Jun 26, 2025
3 checks passed
@justinformatik justinformatik deleted the crunching branch July 23, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong execution timing due to crunching coefficients
2 participants