-
Notifications
You must be signed in to change notification settings - Fork 500
Rhadamanthys Yara Rule Update #2737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @YungBinary, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the detection logic for the Rhadamanthys Loader by incorporating additional YARA patterns. It also updates the author metadata for the YARA rule to reflect contributions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds two new patterns to the Rhadamanthys YARA rule to improve detection and credits a new author. One of the new patterns, $beef, appears to be strong and specific. However, the other new pattern, $config_2, is somewhat generic due to a high number of wildcards, which could potentially lead to false positives. I have added a comment with a suggestion to make it more specific if possible.
| $code = {8B 4D FC 3B CF 8B C1 74 0D 83 78 04 02 74 1C 8B 40 1C 3B C7 75 F3 3B CF 8B C1 74 57 83 78 04 17 74 09 8B 40 1C 3B C7 75 F3 EB} | ||
| $conf = {46 BB FF 00 00 00 23 F3 0F B6 44 31 08 03 F8 23 FB 0F B6 5C 39 08 88 5C 31 08 88 44 39 08 02 C3 8B 5D 08 0F B6 C0 8A 44 08 08} | ||
| $beef = { 57 8D 44 33 FC 53 83 C6 FC 50 56 E8 ?? ?? ?? ?? 83 C4 10 66 81 3F EF BE 0F 85 E6 02 00 00 } | ||
| $config_2 = { 0F B6 4F 2A 8D 77 2A 33 C0 6A 03 89 ?? ?? 89 ?? ?? 89 ?? ?? 8B C1 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new string $config_2 seems a bit generic due to the repeated use of 89 ?? ??. This pattern corresponds to a 3-byte mov instruction like mov [reg+disp8], reg, where both the registers and the displacement are wildcards. With 6 wildcard bytes out of 19 total, this string might be prone to false positives, especially with a 2 of them condition.
Could this be made more specific by filling in some of the ?? bytes if the registers or displacements are constant across samples? A more specific signature would improve the reliability of the detection.
Additional Rhadamanthys patterns