Add ShouldGenerateFile annotation #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexeyinkin
commented
Aug 28, 2024
alexeyinkin
commented
- Rebased copy of Add ShouldGenerateFile annotation #32
alexeyinkin
commented
Aug 28, 2024
| expect( | ||
| reader.allElements.map((e) { | ||
| // https://github.com/dart-lang/sdk/issues/52280 |
There was a problem hiding this comment.
This issue has been resolved, cleaning up.
Comment on lines
+11
to
+13
| - 'test/src/goldens/test_library_file_no_part.dart' | ||
| - 'test/src/goldens/test_library_file_part_of.dart' | ||
| - 'test/src/goldens/test_library_file_part_of_current.dart' |
There was a problem hiding this comment.
For some reason, just excluding test/src/goldens entirely leaves out some issues in test/src/goldens/test_library_file_part_of_current.dart on my machine (Dart 3.5.1), although it ignores other files there.
This could be a bug in the analyzer. I don't have time to investigate or strip down a minimal reproducible example.
There was a problem hiding this comment.
analyzer has had some issues lately w/ analysis_options and mono repos
|
Wonderful! Thank you! |
|
I'm so excited for this! @kevmoo how often do you publish releases to pub? (not trying to rush, jw) |
|
@btrautmann I can do it now! |
|
Published! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.