Skip to content

add ops.layer_normalization #21327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 27, 2025
Merged

add ops.layer_normalization #21327

merged 6 commits into from
May 27, 2025

Conversation

pass-lin
Copy link
Contributor

@pass-lin pass-lin commented May 27, 2025

from #21313 and #21323
To improve the performance of the torch backend, we add a new op and use the cudnn operator of the torch in this op

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2025

Codecov Report

Attention: Patch coverage is 87.93103% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.59%. Comparing base (240d4f4) to head (48fb1c6).

Files with missing lines Patch % Lines
keras/src/ops/nn.py 90.56% 3 Missing and 2 partials ⚠️
keras/api/_tf_keras/keras/ops/__init__.py 0.00% 1 Missing ⚠️
keras/api/_tf_keras/keras/ops/nn/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21327   +/-   ##
=======================================
  Coverage   82.58%   82.59%           
=======================================
  Files         565      565           
  Lines       54819    54850   +31     
  Branches     8516     8520    +4     
=======================================
+ Hits        45273    45303   +30     
+ Misses       7454     7452    -2     
- Partials     2092     2095    +3     
Flag Coverage Δ
keras 82.40% <86.20%> (+<0.01%) ⬆️
keras-jax 63.53% <81.03%> (+<0.01%) ⬆️
keras-numpy 58.69% <74.13%> (+<0.01%) ⬆️
keras-openvino 33.11% <58.62%> (-0.01%) ⬇️
keras-tensorflow 63.94% <81.03%> (+<0.01%) ⬆️
keras-torch 63.59% <63.79%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the refactor.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels May 27, 2025
@fchollet fchollet merged commit 86638c2 into keras-team:master May 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull Ready to be merged into the codebase size:M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants