Skip to content

Implement hanning function in keras.ops #21318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged

Conversation

shashaka
Copy link
Contributor

Adds keras.ops.hanning, which computes the Hanning window. Supported across NumPy, TensorFlow, PyTorch, and JAX backends, but not supported on OpenVINO.

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.60%. Comparing base (785c9b0) to head (ef02d17).

Files with missing lines Patch % Lines
keras/src/ops/numpy.py 80.00% 1 Missing and 1 partial ⚠️
keras/api/_tf_keras/keras/ops/__init__.py 0.00% 1 Missing ⚠️
keras/api/_tf_keras/keras/ops/numpy/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21318   +/-   ##
=======================================
  Coverage   82.60%   82.60%           
=======================================
  Files         565      565           
  Lines       54773    54799   +26     
  Branches     8508     8509    +1     
=======================================
+ Hits        45244    45266   +22     
- Misses       7439     7442    +3     
- Partials     2090     2091    +1     
Flag Coverage Δ
keras 82.41% <84.61%> (+<0.01%) ⬆️
keras-jax 63.55% <57.69%> (-0.01%) ⬇️
keras-numpy 58.71% <61.53%> (-0.01%) ⬇️
keras-openvino 33.13% <34.61%> (+<0.01%) ⬆️
keras-tensorflow 63.96% <57.69%> (-0.01%) ⬇️
keras-torch 63.62% <57.69%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels May 22, 2025
@fchollet fchollet merged commit 6b74cb0 into keras-team:master May 22, 2025
8 checks passed
@shashaka shashaka deleted the hanning branch May 22, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run ready to pull Ready to be merged into the codebase size:M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants