Updated random_grayscale.py compute_output_spec #21312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected indentation in doc string
Fixed issue with passing a single image without batch dimension.
…scale.py Co-authored-by: Jyotinder Singh <33001894+JyotinderSingh@users.noreply.github.com>
Test case for unbatched inputs
Testcase for checking both unbatched and batched single image inputs.
There was a bug, and it was causing cycle in graph.
pctablet505
requested review from
hertschuh and
abheesht17
and removed request for
JyotinderSingh
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21312 +/- ##
=======================================
Coverage 82.60% 82.60%
=======================================
Files 565 565
Lines 54772 54773 +1
Branches 8508 8508
=======================================
+ Hits 45243 45244 +1
Misses 7439 7439
Partials 2090 2090
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JyotinderSingh
approved these changes
May 21, 2025
google-ml-butler
bot
added
kokoro:force-run
ready to pull
|
Looks like I don't have write access either |
google-ml-butler
bot
removed
awaiting review
ready to pull
hertschuh
reviewed
May 21, 2025
| @@ -96,7 +97,12 @@ def compute_output_shape(self, input_shape): | |||
| return input_shape | |||
|
|
|||
| def compute_output_spec(self, inputs, **kwargs): | |||
| return inputs | |||
| return tree.map_structure( | |||
There was a problem hiding this comment.
There should not be a tree.map_structure in this case, there is a single input tensor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21268: Updates
compute_output_specinrandom_grayscale.pyto prevent a computation graph cycle error whenRandomGrayscaleis used as part of a custom image augmentation pipeline.