Sharded weights type error #2296
Open
+43
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laxmareddyp
changed the title
|
@laxmareddyp could we add a test for this to prevent future breakage? Here is an example of testing sharded weights: |
Comment on lines
67
to
84
| init_kwargs = { | ||
| "vocabulary_size": 1024, | ||
| "num_layers": 12, | ||
| "num_query_heads": 8, | ||
| "num_key_value_heads": 4, | ||
| "hidden_dim": 32, | ||
| "intermediate_dim": 64, | ||
| "head_dim": 4, | ||
| "sliding_window_size": 5, | ||
| "attention_logit_soft_cap": 50, | ||
| "final_logit_soft_cap": 30, | ||
| "layer_norm_epsilon": 1e-6, | ||
| "query_head_dim_normalize": False, | ||
| "use_post_ffw_norm": True, | ||
| "use_post_attention_norm": True, | ||
| "use_sliding_window_attention": True, | ||
| } | ||
| backbone = GemmaBackbone(**init_kwargs) # ~422KB |
There was a problem hiding this comment.
Can you move this to setUp and use it for all 3 test cases which we are doing here, so that our test setup will be lot more cleaner.
…l three relevant test cases to use the shared setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fix: Handle lists in weight_map for sharded weights
The
_get_sharded_filenamesmethod inpreset_utils.pywas raising aTypeError when
weight_map.values()contained lists. This occurred becauselists are unhashable and cannot be added directly to a set.
Reference
Colab Notebook
Checklist