Skip to content

Fix pipelines: [docs] Adjust Vale Doc Linter and Prettier configurations Issue #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pratik-mahalle
Copy link

What has changed?
This pull request addresses the issues with failing Vale Doc Linter and Prettier pipelines as described in Issue #2696.

  • Fixed numerous spelling and style errors flagged by Vale across the documentation files.
  • Corrected branch/tag references in the Prettier pipeline configuration.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
@pratik-mahalle pratik-mahalle requested a review from nehagup as a code owner May 16, 2025 06:20
Copy link

keploy bot commented May 16, 2025

Nice Pr 😄. We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

@pratik-mahalle pratik-mahalle changed the title Fix pipelines: [docs] Adjust Vale Doc Linter and Prettier configurations Issue #2696 Fix pipelines: [docs] Adjust Vale Doc Linter and Prettier configurations Issue May 16, 2025
@Achanandhi-M
Copy link
Contributor

Hi @pratik-mahalle, thanks for raising the PR!
I’m a bit confused about the number of files changed—especially since the issue seems to be related to a linter problem. Could you please elaborate on the changes, particularly why files like vale_styles/Google/GenderBias.yml were modified? It would help me better understand the context of the PR. Thanks!

@pratik-mahalle
Copy link
Author

Hey @Achanandhi-M, Thank you for the review. I think, the main goal of this PR was to adjust the Vale Doc Linter and Prettier configurations to resolve the linter issues we were encountering. As part of this, I needed to update some of the custom style files, including vale_styles/Google/GenderBias.yml, to ensure they aligned with our current linting rules and addressed the specific problems flagged by Vale.

@Achanandhi-M
Copy link
Contributor

I’ll get it reviewed by the team and follow up on the merge soon @pratik-mahalle

@khareyash05
Copy link
Contributor

The pipelines are still failing @pratik-mahalle

@pratik-mahalle
Copy link
Author

pratik-mahalle commented May 21, 2025

Hey @khareyash05 , In vale-lint-action.yml only the versioned_docs/version-2.0.0 directory is checked. Are we want to check only that folder?

@pratik-mahalle
Copy link
Author

Let me try pushing the recent changes, if it works!

…go types - Fix ordinal numbers and unit spacing - Fix quote punctuation - Fix em dash spacing

Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
…go types - Fix ordinal numbers and unit spacing - Fix quote punctuation - Fix em dash spacing

Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Signed-off-by: Pratik Mahalle <mahallepratik683@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants