Skip to content

Conversation

pettai
Copy link
Contributor

@pettai pettai commented Oct 19, 2024

This update parses some additional fields/state that surface during (manual) zone transfers

@kellyjonbrazil
Copy link
Owner

Looks good - do we need to update the schema with the new fields?

@pettai
Copy link
Contributor Author

pettai commented Oct 20, 2024

Ah, I started on that at first, but since it it's either wait: string or notified-serial: string + transfer: string, I backed it, and then I forgot about that while doing the actual update + tests. is there a way of describing optional / shifting fields? or do we simply copy-n-paste with modifications?
I noticed there are two more ("optional") fields missing from earlier additions too...

@kellyjonbrazil
Copy link
Owner

I just add all of the possible fields. I try not to have fields with multiple possible types, but if that’s impossible to avoid I just add a comment to describe the behavior. If it’s more than a few words I do it with a footnote so it doesn’t pass 80 chars in the row.

@kellyjonbrazil kellyjonbrazil merged commit a8b231d into kellyjonbrazil:dev Nov 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants