Skip to content

Conversation

diegovb-sys
Copy link
Contributor

Closes #5374

πŸ“‘ Description

This PR only wraps the function to check if an alert is inside of a maintenance window with a try/except block.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@vercel
Copy link

vercel bot commented Oct 20, 2025

@diegovb-sys is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. API API related issues labels Oct 20, 2025
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
βœ… Project coverage is 46.39%. Comparing base (57ca737) to head (fddaf9c).
⚠️ Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/bl/maintenance_windows_bl.py 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5375      +/-   ##
==========================================
- Coverage   46.64%   46.39%   -0.26%     
==========================================
  Files         175      176       +1     
  Lines       18263    18415     +152     
==========================================
+ Hits         8519     8543      +24     
- Misses       9744     9872     +128     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 20, 2025
@vercel
Copy link

vercel bot commented Oct 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
keep Ignored Ignored Preview Oct 20, 2025 0:33am

πŸ’‘ Enable Vercel Agent with $100 free credit for automated AI reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API API related issues lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[βž• Feature]: Avoid maintenance window crash in main flow

2 participants