-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: added a new pkce string generator and use that in oauth handshake #5323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Someone is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
Arvid HΓ₯kansson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5323 +/- ##
===========================================
- Coverage 46.64% 30.61% -16.04%
===========================================
Files 175 101 -74
Lines 18263 11638 -6625
===========================================
- Hits 8519 3563 -4956
+ Misses 9744 8075 -1669 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@battkajs can you sign CLA so I can merge? |
@shahargl I had forgot to add my email to the git config. Could this be bypassed or should I re-do the PR? EDIT: I did a git amend with my email present, I have successfully accepted the terms but the bot workflow dont pick it up. |
197e89d
to
a822b34
Compare
π Well done @battkajs! Two PRs merged already! ππ₯³ With your second PR, you're on a roll, and your contributions are already making a difference. π |
Closes #5322
π Description
Added a helper function to generate a random string of 128 characters compliant with RFC7636: https://datatracker.ietf.org/doc/html/rfc7636
β Checks
βΉ Additional Information