Skip to content

Conversation

battkajs
Copy link
Contributor

Closes #5322

πŸ“‘ Description

Added a helper function to generate a random string of 128 characters compliant with RFC7636: https://datatracker.ietf.org/doc/html/rfc7636

βœ… Checks

  • [ x] My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@vercel
Copy link

vercel bot commented Sep 18, 2025

Someone is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Arvid HΓ₯kansson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Feature A new feature labels Sep 18, 2025
@battkajs battkajs changed the title added a new pkce string generator and use that in oauth handshake fix: added a new pkce string generator and use that in oauth handshake Sep 18, 2025
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 30.61%. Comparing base (57ca737) to head (197e89d).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5323       +/-   ##
===========================================
- Coverage   46.64%   30.61%   -16.04%     
===========================================
  Files         175      101       -74     
  Lines       18263    11638     -6625     
===========================================
- Hits         8519     3563     -4956     
+ Misses       9744     8075     -1669     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shahargl shahargl self-requested a review September 18, 2025 14:32
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 18, 2025
@vercel
Copy link

vercel bot commented Sep 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
keep Ready Ready Preview Comment Sep 20, 2025 3:42am

@shahargl
Copy link
Member

@battkajs can you sign CLA so I can merge?

@battkajs
Copy link
Contributor Author

battkajs commented Sep 19, 2025

@shahargl I had forgot to add my email to the git config. Could this be bypassed or should I re-do the PR?

EDIT: I did a git amend with my email present, I have successfully accepted the terms but the bot workflow dont pick it up.

@shahargl shahargl enabled auto-merge (squash) September 20, 2025 03:36
@shahargl shahargl merged commit 41d225d into keephq:main Sep 20, 2025
12 of 13 checks passed
@github-actions
Copy link
Contributor

🌟 Well done @battkajs! Two PRs merged already! πŸŽ‰πŸ₯³

With your second PR, you're on a roll, and your contributions are already making a difference. 🌟
Looking forward to seeing even more contributions from you. See you in Slack https://slack.keephq.dev πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature A new feature lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[πŸ› Bug]: Fail OAuth Handshake Pagerduty

3 participants