Skip to content

fix: Webhook provider uses dummy payload for validation #5320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2025
Merged

fix: Webhook provider uses dummy payload for validation #5320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
894d951
fix: Webhook provider uses dummy payload for validation
yosizelensky Sep 17, 2025
f3fc2ea
fix tests
yosizelensky Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions keep/providers/webhook_provider/webhook_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,14 +124,12 @@ def dispose(self):

def validate_scopes(self) -> dict[str, bool | str]:
validated_scopes = {}
# try to send the webhook with TEST payload
try:
self._notify(body={"test": "payload"})
self.__validate_url(str(self.authentication_config.url))
validated_scopes["send_webhook"] = True
except Exception as e:
self.logger.exception("Error validating scopes")
self.logger.exception("Error validating webhook URL")
validated_scopes["send_webhook"] = str(e)
return validated_scopes
validated_scopes["send_webhook"] = True
return validated_scopes

def validate_config(self):
Expand Down
5 changes: 3 additions & 2 deletions tests/e2e_tests/test_end_to_end.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,15 +367,16 @@ def test_provider_deletion(browser: Page):
f"button:has-text('Webhook'):has-text('Connected'):has-text('{provider_name}')"
).click()
browser.get_by_placeholder("Enter url").clear()
browser.get_by_placeholder("Enter url").fill("https://this_is_UwU")
# Use a blacklisted URL to trigger validation error
browser.get_by_placeholder("Enter url").fill("https://metadata.google.internal/test")

browser.get_by_role("button", name="Update", exact=True).click()
browser.wait_for_timeout(500)
# Refreshing the scope
browser.get_by_role("button", name="Validate Scopes", exact=True).click()
browser.wait_for_timeout(500)
assert_scope_text_count(
browser=browser, contains_text="HTTPSConnectionPool", count=1
browser=browser, contains_text="blacklisted", count=1
)
browser.mouse.click(10, 10)
delete_provider(
Expand Down
Loading